Fix: pagination not shown in donation history #8111
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A donor has in my example 96 donations, but only 16 are completed. Only the 20 first are displayed. The function give_count_donations_of_donor() calls give_get_donation_stats_by_user( $user ), and $donor->purchase_count is used to count the donation. But this attr counts only the completed donations, and in the donation history, all donations are displayed (status any). I suggested to use $donor->payment_ids that contains all donations, and count them.
|
This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed. |
| $stats = ! empty( $user ) ? give_get_donation_stats_by_user( $user ) : false; | ||
|
|
||
| return isset( $stats['purchases'] ) ? $stats['purchases'] : 0; | ||
| return isset( $stats['donations_count'] ) ? $stats['donations_count'] : 0; |
Contributor
There was a problem hiding this comment.
If the donation history shortcode has a status param, you might want to account for that here so the pagination works for any or completed/publish
Suggested change
| return isset( $stats['donations_count'] ) ? $stats['donations_count'] : 0; | |
| return $status === 'any' ? ($stats['donations_count'] ?? 0) : ($stats['purchases'] ?? 0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my example, a donor has made 96 donations, but only 16 are completed. Only the 20 first are displayed in the donation history. Explanation: The
give_count_donations_of_donor()function callsgive_get_donation_stats_by_user( $user ), and$donor->purchase_countis used to count donations. However this attribute counts only completed donations, whereas in the donation history, all donations are displayed (statusany). As 16 < 20, pagination is not necessary.I suggested using
$donor->payment_idswhich contains all donations, and counting them.