Skip to content

Conversation

@jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Jan 16, 2026

Resolves GIVE-3047

Description

This fixes issues with the view_give_forms permissions on existing sites

Affects

  • Existing user roles viewing campaigns in the admin

Visuals

N/A

Testing Instructions

ZIP: https://github.com/impress-org/givewp/actions/runs/21143224994

  • Before using this PR, create a site with the latest version of GiveWP (master branch) and add user roles like admin and give manager
  • Update the existing site to this PR
  • Make sure they can see the campaign page and menu item in admin
  • You can also use the user role editor plugin to check for view_give_forms permissions directly

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review January 19, 2026 15:45
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonwaldstein Thanks for this fix! Great work with the tests covering a lot of scenarios.

I left a comment related to a minor thing, but overall it's working well - I followed the tests intructions an it worked as expected. Ready to QA!

* Register migrations for legacy components.
*
* @unreleased add AddViewCapabilitiesToAdminRoles migration
* @unreleased add FixGiveWorkerCapabilities migration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we consolidate these changes into a single unreleased tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved 178d6f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants