Skip to content

Comments

Fix: Improve donation form modal on mobile#8206

Merged
pauloiankoski merged 5 commits intodevelopfrom
fix/GIVE-3057
Feb 18, 2026
Merged

Fix: Improve donation form modal on mobile#8206
pauloiankoski merged 5 commits intodevelopfrom
fix/GIVE-3057

Conversation

@pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Feb 5, 2026

Resolves GIVE-3057

Description

When opening a donation form modal on a mobile device, the overlay element experiences layout issues when the virtual keyboard appears. This creates a poor user experience as users attempt to fill out the donation form, with the overlay and modal positioning becoming unstable.

This PR removes the custom --visual-viewport-height property and uses 100dvh instead. Now the overlay uses the viewport height provided by the browser, which improves how the modal behaves on mobile when the virtual keyboard appears.

See the issue:

ScreenRecording_10-29-2025.09-27-40_1.MP4

Affects

Donation Form Modal

Visuals

CleanShot.2026-02-09.at.18.14.37.mp4

Testing Instructions

  1. Create a new GiveWP > Campaign, publish the campaign page with the defaults
  2. View the campaign page, and click the Donate on a mobile device.
  3. Try to complete a donation.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein self-requested a review February 5, 2026 14:16
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be careful with this one as the modal needs to be compatible with different form designs and screen sizes 😄

Image

@pauloiankoski
Copy link
Contributor Author

@jonwaldstein I reverted all commits and added a new one just replacing --visual-viewport-height with 100dvh.

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pauloiankoski thanks for the update, this should do the job 😄

@pauloiankoski pauloiankoski merged commit 5b0dcb7 into develop Feb 18, 2026
25 checks passed
@pauloiankoski pauloiankoski deleted the fix/GIVE-3057 branch February 18, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants