Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds macOS platform support to the Swift Package Manager configuration and updates the GitHub Actions workflow to use a specific macOS runner version.
Changes:
- Added macOS v11 as a minimum supported platform in the Swift package definition
- Updated GitHub Actions workflow to use macos-15 runner instead of macos-latest
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Package.swift | Added macOS v11 to the platforms array to enable macOS support |
| .github/workflows/swift.yml | Pinned the workflow runner to macos-15 for consistent build environment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let package = Package( | ||
| name: "Improv-iOS", | ||
| platforms: [.iOS(.v14)], | ||
| platforms: [.iOS(.v14), .macOS(.v11)], |
There was a problem hiding this comment.
The macOS minimum version is set to v11 here, but the podspec file (Improv-iOS.podspec line 27) specifies macOS 12.0 as the minimum deployment target. This inconsistency could lead to confusion and potentially different behavior between Swift Package Manager and CocoaPods installations. Consider aligning both to use the same minimum macOS version.
| platforms: [.iOS(.v14), .macOS(.v11)], | |
| platforms: [.iOS(.v14), .macOS(.v12)], |
1 participant
No description provided.