feat: added CreateIfNotExists option #47
Conversation
f1nzer
force-pushed
the
feat/create-if-not-exists
branch
3 times, most recently
from
9511c03 to
b6992fa
Compare
f1nzer
force-pushed
the
feat/create-if-not-exists
branch
from
b6992fa to
7bc5c09
Compare
|
@imranmomin can you please review/merge this PR? |
| try | ||
| { | ||
| Container = await Client.GetContainer(databaseName, containerName).ReadContainerAsync(cancellationToken: cancellationToken); | ||
| return; |
There was a problem hiding this comment.
Cannot exit from here, as there are some dependencies that need to be created on the container.
There was a problem hiding this comment.
The idea behind this change is that I have a hangfire server app (responsible for job processing) and a hangfire client app (job scheduling only).
As for the hangfire server, I want to use CreateIfNotExists=true to preserve my database up-to-date with possible changes on this library side.
On the other hand, my clients are just clients, and I want to make them:
- use ManagedIdentity (now it supports only data-plane operations)
- have a fast startup/first query time (no need to upload multiple stored procedures and so on)
There is a DistributedCache library where the same flag is implemented: https://github.com/Azure/Microsoft.Extensions.Caching.Cosmos/blob/master/src/CosmosCache.cs#L447
Of course, there are no stored procedures, but the database might also be broken due to this flag (incorrect pk, etc.)
There was a problem hiding this comment.
Anyway, another option (suggestion) is to store some kind of hash, that is based on a procedure's content as a single entry in a database (something similar to EF migration tables). So, if the hash entry is missing or the hash value differs from the calculated value then there is no need to upload stored procedures. It will use a bit more CPU time and 1 GET request instead of calling Get + Create/Replace for every procedure.
Using this hash-based approach we could get rid of several (non-friendly for RBAC) calls and speedup initialization in general.
It's not always neccessary to perform db initialization on every run.
Also, users might have issues with db/container/stored procedures creation when native RBAC is enabled due to management operation limitations: https://aka.ms/cosmos-native-rbac
New option
CreateIfNotExistsis enabled by default (to preserve the current behavior).