fix(input): handle Ctrl+C via SIGINT signal instead of keypress#491
Merged
cyqsimon merged 4 commits intoimsnif:mainfrom Feb 11, 2026
Merged
fix(input): handle Ctrl+C via SIGINT signal instead of keypress#491cyqsimon merged 4 commits intoimsnif:mainfrom
cyqsimon merged 4 commits intoimsnif:mainfrom
Conversation
d1dea20 to
72cf7c5
Compare
72cf7c5 to
5909d45
Compare
cyqsimon
reviewed
Feb 11, 2026
Contributor
Author
|
I noticed a hang issue when receiving a SIGINT. The Fix:
|
cyqsimon
reviewed
Feb 11, 2026
Collaborator
cyqsimon
left a comment
There was a problem hiding this comment.
Don't worry about the Windows test failures. CI downloads npcap but for some reason it's unreliable. Haven't had time to check why yet.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #487
Previously, bandwhich intercepted Ctrl+C as a keyboard event, which caused it to exit even when users had disabled SIGINT via
stty intr ^-.Now uses the
ctrlccrate to properly handle the SIGINT signal. Theqkey remains as the keyboard-based quit option.