Fix confusing error message on macOS when running without sudo#492
Open
chiranjeevi-max wants to merge 2 commits into
Open
Fix confusing error message on macOS when running without sudo#492chiranjeevi-max wants to merge 2 commits into
chiranjeevi-max wants to merge 2 commits into
Conversation
fcdd3ca to
d81fbf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #486
On macOS, when running
bandwhichwithout elevated privileges, users see confusing error messages like:This happens because macOS returns
ENOENTinstead ofEPERMwhen accessing BPF devices without permission.with this PR, the program treats
ErrorKind::NotFoundas a permission error on macOS/FreeBSD, so users now see the helpful message: