fix(os): handle empty error messages from pnet on bonding interfaces#496
Open
hieuit095 wants to merge 1 commit into
Open
fix(os): handle empty error messages from pnet on bonding interfaces#496hieuit095 wants to merge 1 commit into
hieuit095 wants to merge 1 commit into
Conversation
When all frame receivers fail and both error lists are empty (which can occur on IEEE 802.3ad bonding/team interfaces where pnet returns errors with empty messages), the code previously hit an unreachable! panic. Replace the panic with a graceful error message that explains the situation and mentions bonding/team interfaces as a known cause. Fixes imsnif#364.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When all frame receivers fail and both error lists are empty (which can occur on IEEE 802.3ad bonding/team interfaces where pnet returns errors with empty messages), the code previously hit an unreachable! panic.
Replace the panic with a graceful error message that explains the situation and mentions bonding/team interfaces as a known cause.
On systems with IEEE 802.3ad dynamic link aggregation (LACP), attempting to use bandwhich on the bonding interface or its member interfaces results in a panic instead of a user-friendly error message. The root cause is that the pnet library can return errors with empty messages on bonding interfaces, causing both error categorization lists to be empty while still entering the error handling path.