Add SAI DMA peripheral traits and DMA-related helpers#194
Merged
Conversation
mciantyre
reviewed
Mar 8, 2026
mciantyre
left a comment
Member
There was a problem hiding this comment.
Generally looks OK. I'll add a CHANGELOG feature entry if you don't get around to it.
Contributor
Author
|
Also, I cherry-picked the compilation bug and put it in that separate PR, so I'm going to rebase and force push and see what happens to the PR! |
6f6fcde to
7695206
Compare
Add DMA support for SAI (Serial Audio Interface) transmit and receive: - Implement Destination<u32> for sai::Tx (DMA can write to TX FIFO) - Implement Source<u32> for sai::Rx (DMA can read from RX FIFO) - Add SAI DMA MUX source mappings for SAI1/SAI2/SAI3 - Add channel(), tdr()/rdr() accessors for DMA address setup - Add enable/disable_dma_transmit/receive methods (FWDE/FRDE bits) - Store data channel index in Tx/Rx structs from split() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
After a few misfires, I think we're clean! |
mciantyre
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add DMA support for SAI (Serial Audio Interface) transmit and receive:
Also fix conditional compilation in logging crate to gate lpuart/usbd enum variants on their respective features, and add *.hex to gitignore.