logging: feature-gate Inner enum variants for lpuart/usbd#195
Merged
Conversation
The Inner enum and its From impls/match arms referenced lpuart::Backend and usbd::Backend unconditionally, causing compilation errors when only one backend feature (e.g. lpuart but not usbd) was enabled. Add #[cfg(feature = ...)] gates to each variant, From impl, and match arm so the crate compiles with any valid subset of backend features.
mciantyre
approved these changes
Mar 8, 2026
mciantyre
left a comment
mciantyre
left a comment
Member
There was a problem hiding this comment.
Looks great. And thanks for documenting the problem! I included some CI tests so we can catch that going forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Inner enum and its From impls/match arms referenced lpuart::Backend and usbd::Backend unconditionally, causing compilation errors when only one backend feature (e.g. lpuart but not usbd) was enabled.
Add #[cfg(feature = ...)] gates to each variant, From impl, and match arm so the crate compiles with any valid subset of backend features.