Skip to content

fix: mysql conn string requirement#639

Closed
manzil-infinity180 wants to merge 1 commit intoin-toto:mainfrom
manzil-infinity180:mysql-conn-string
Closed

fix: mysql conn string requirement#639
manzil-infinity180 wants to merge 1 commit intoin-toto:mainfrom
manzil-infinity180:mysql-conn-string

Conversation

@manzil-infinity180
Copy link
Copy Markdown
Contributor

@manzil-infinity180 manzil-infinity180 commented Oct 10, 2025

What this PR does / why we need it

Description

This adds a function to ensure the connection string has tcp() wrapped around host part. This is required by the go-sql-driver but not required by atlas for DB migration,
From the pr - fix(#560): Fix MYSQL Conn string requirements #565
I added additional test to it

Fixes #560

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

@manzil-infinity180
Copy link
Copy Markdown
Contributor Author

@jkjell please approve for ci run

@jkjell jkjell force-pushed the mysql-conn-string branch from 78417ec to d8164ed Compare October 14, 2025 18:59
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 1.56%. Comparing base (a035c62) to head (9cced6f).
⚠️ Report is 411 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #639       +/-   ##
==========================================
- Coverage   82.40%   1.56%   -80.85%     
==========================================
  Files          10     127      +117     
  Lines         358   34583    +34225     
==========================================
+ Hits          295     540      +245     
- Misses         43   33975    +33932     
- Partials       20      68       +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Rahul Vishwakarma <rahulvs2809@gmail.com>
@jkjell jkjell force-pushed the mysql-conn-string branch from d8164ed to 9cced6f Compare October 15, 2025 22:13
@manzil-infinity180
Copy link
Copy Markdown
Contributor Author

Closing this, I thought #565 is failing reason he raised it from main branch adding the licence header to #565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent MYSQL connection string requirements

1 participant