[RELEASE] Version 9.4.0 with redirects support

New feature: Redirects Support. This version contains a new module
which allows to publish specific redirects to the foreign system.

Bug fixes: Several bugs have been fixed, including
* Ignore sys_domain if the table does not exist
* Fixed identification of the PID in the Backend by data operations
* Removed visual bug with missing background color
* Type cast values to their expected type
* Publishing behavior with tranlsations and originals
* URL generation for deleted records
* Shared runtime cache of the RecordFactory
and much more

Releases: https://projekte.in2code.de/issues/31914
Releases: https://projekte.in2code.de/issues/40689
Releases: https://projekte.in2code.de/issues/45262
Releases: https://projekte.in2code.de/issues/45441
Releases: https://projekte.in2code.de/issues/45453
Releases: https://projekte.in2code.de/issues/45468
Releases: https://projekte.in2code.de/issues/45430
Releases: https://projekte.in2code.de/issues/45502
Releases: https://projekte.in2code.de/issues/45509
Releases: https://projekte.in2code.de/issues/45517
Releases: https://projekte.in2code.de/issues/45441
Releases: https://projekte.in2code.de/issues/45276

Resolves: https://projekte.in2code.de/issues/45412

Author: vertexvaar

.editorconfig

@@ -58,3 +58,8 @@ indent_size = 2
 [.eslintrc]
 indent_style = space
 indent_size = 4
+
+# https://docs.typo3.org/m/typo3/reference-coreapi/10.4/en-us/CodingGuidelines/CglTypoScript/Index.html
+[{ext_typoscript_setup.txt, *.typoscript, setup.txt, constants.txt, setup.ts, constants.ts}]
+indent_style = space
+indent_size = 2

.gitattributes

@@ -1,5 +1,6 @@
 # .gitattributes
 
+Build                          export-ignore
 .gitkeep                       export-ignore
 /.editorconfig                 export-ignore
 /.gitattributes                export-ignore

CHANGELOG.md

@@ -1,5 +1,59 @@
 # In2publish Core Change Log
 
+9.4.0:
+
+- [META] Set the branch alias version number to 9.4.x-dev
+- [META] Set the EM conf version number to 9.4.0
+- [BUGFIX] Fix exception when publishing deleted redirects
+- [TASK] remove unused import and use right indent
+- [TASK] enable publish deletion of redirects
+- [BUGFIX] Remove redundant module.m5 option, add docs for redirects support
+- [BUGFIX] Publish redirects which were filtered becasue they are deleted and unpublished
+- [BUGFIX] Add test to identify site config language differences
+- [BUGFIX] Provide missing icons for TYPO3 v9
+- [BUGFIX] Always publish language originals
+- [TASK] publish default and translated page
+- [BUGFIX] Add missing exception code
+- [TYPO] transission -> transmission
+- [BUGFIX] Never relate redirects by their PID
+- [BUGFIX] Share the RecordFactories runtimeCache between instances
+- [BUGFIX] Skip URL generation for deleted pages
+- [BUGFIX] Publish translation original when publishing via specific record publishing
+- [BUGFIX] Check if the pointer field is set before accessing it
+- [TASK] publish default and translated page
+- [BUGFIX] Do not enable redirects support when EXT:redirects is not loaded
+- [BUGFIX] Typecast properties to be used in str_replace
+- [FEATURE] Support TYPO3 redirects
+- [DOCS] Add known issue for missing icons in publish redirect module in v9
+- [CODESTYLE] Reformat TypoScript and add editorconfig rules
+- [BUGFIX] Add extbase table mapping for TYPO3 version 9
+- [BUGFIX] Remove trailing method call comma for PHP 7.2 compat
+- [BUGFIX] Replace Command::SUCCESS constant with 0 for TYPO3 v9
+- [BUGFIX] Skip constraint for deleted redirects if none are deleted on foreign
+- [FEATURE] Rebuild redirects cache after publishing a redirect
+- [BUGFIX] Hide the edit button for deleted records
+- [FEATURE] Exclude fully deleted redirects from the module
+- [BUGFIX] Include deleted redirects
+- [FEATURE] Remove discarded concepts, add support in simplePublish
+- Wip: [FEATURE] Finish backend module for redirect publishing
+- Wip: [FEATURE] List all redirects with state and publish button
+- Wip: [FEATURE] Add Backend Module to publish redirects
+- [BUGFIX] Ignore pages without sites
+- [BUGFIX] Resolve redirects recursively
+- [FEATURE] Resolve relations to TYPO3 v10 redirects and publish them with changed source_host
+- [BUGFIX] Do not log failed site searches for disconnected pages.
+- [BUGFIX] Output non-breaking space if no preview URL could be rendered.
+- [FEATURE] Show dirty properties for deleted records
+- [BUGFIX] Show foreign properties on dirty properties foreign side
+- [TASK] show properties if deleted on right side
+- [TASK] show deletion state and history button
+- [BUGFIX] Skip DataHandler cmdmap with integer keys in getPageIdentifier
+- [BUGFIX] Detect pid from newly created records
+- [REFACTOR] Move ssh connection debug option to ssh connection definer
+- [BUGFIX] Do not select from sys_domain if table does not exist
+- [GIT] Don't export the Build folder into releases
+- [RELEASE] Version 9.3.1 with fixes for TCA pre proc., empty pointer values and deleted records
+
 9.3.1:
 
 - [META] Set the EM conf version number to 9.3.1

Classes/Command/Status/AllSitesCommand.php

@@ -0,0 +1,59 @@
+<?php
+
+declare(strict_types=1);
+
+namespace In2code\In2publishCore\Command\Status;
+
+/*
+ * Copyright notice
+ *
+ * (c) 2021 in2code.de and the following authors:
+ * Oliver Eglseder <[email protected]>
+ *
+ * All rights reserved
+ *
+ * This script is part of the TYPO3 project. The TYPO3 project is
+ * free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * The GNU General Public License can be found at
+ * http://www.gnu.org/copyleft/gpl.html.
+ *
+ * This script is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * This copyright notice MUST APPEAR in all copies of the script!
+ */
+
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use TYPO3\CMS\Core\Site\SiteFinder;
+use TYPO3\CMS\Core\Utility\GeneralUtility;
+
+use function base64_encode;
+use function serialize;
+
+class AllSitesCommand extends Command
+{
+    public const DESCRIPTION = 'Prints all Sites serialized and encoded. Internal CLI API.';
+    public const IDENTIFIER = 'in2publish_core:status:allsites';
+
+    protected function configure(): void
+    {
+        $this->setDescription(self::DESCRIPTION)
+             ->setHidden(true);
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output): int
+    {
+        $siteFinder = GeneralUtility::makeInstance(SiteFinder::class);
+        $sites = $siteFinder->getAllSites(false);
+        $output->writeln('Sites: ' . base64_encode(serialize($sites)));
+        return 0;
+    }
+}

Classes/Command/Status/SiteConfigurationCommand.php

@@ -30,52 +30,59 @@
  */
 
 use In2code\In2publishCore\Command\Status\Exception\InvalidPageIdArgumentTypeException;
-use In2code\In2publishCore\Utility\ExtensionUtility;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
+use TYPO3\CMS\Core\Exception\Page\PageNotFoundException;
 use TYPO3\CMS\Core\Exception\SiteNotFoundException;
 use TYPO3\CMS\Core\Site\SiteFinder;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
+use TYPO3\CMS\Core\Utility\RootlineUtility;
+
 use function base64_encode;
 use function serialize;
 
 class SiteConfigurationCommand extends Command
 {
     public const ARG_PAGE_ID = 'pageId';
     public const ARG_PAGE_ID_DESCRIPTION = 'The page id to retrieve the site config for';
-    public const DESCRIPTION = 'Prints the version number of the currently installed in2publish_core extension';
+    public const DESCRIPTION = 'Outputs the requested Site serialized and encoded.';
     public const EXIT_NO_SITE = 250;
+    public const EXIT_PAGE_HIDDEN_OR_DISCONNECTED = 251;
     public const IDENTIFIER = 'in2publish_core:status:siteconfiguration';
 
-    protected function configure()
+    protected function configure(): void
     {
         $this->setDescription(self::DESCRIPTION)
              ->addArgument(self::ARG_PAGE_ID, InputArgument::REQUIRED, self::ARG_PAGE_ID_DESCRIPTION)
              ->setHidden(true);
     }
 
-    protected function initialize(InputInterface $input, OutputInterface $output)
+    protected function initialize(InputInterface $input, OutputInterface $output): void
     {
         $pageId = $input->getArgument(self::ARG_PAGE_ID);
         if ($pageId !== (string)(int)$pageId) {
             throw InvalidPageIdArgumentTypeException::fromGivenPageId($pageId);
         }
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $siteFinder = GeneralUtility::makeInstance(SiteFinder::class);
+        $pageId = (int)$input->getArgument(self::ARG_PAGE_ID);
         try {
-            $pageId = (int)$input->getArgument(self::ARG_PAGE_ID);
             $site = $siteFinder->getSiteByPageId($pageId);
         } catch (SiteNotFoundException $e) {
+            try {
+                GeneralUtility::makeInstance(RootlineUtility::class, $pageId, null)->get();
+            } catch (PageNotFoundException $e) {
+                return static::EXIT_PAGE_HIDDEN_OR_DISCONNECTED;
+            }
             return static::EXIT_NO_SITE;
         }
         $output->writeln('Site: ' . base64_encode(serialize($site)));
-        $output->writeln('Version: ' . ExtensionUtility::getExtensionVersion('in2publish_core'));
         return 0;
     }
 }

Classes/Config/Definer/In2publishCoreDefiner.php

@@ -241,7 +241,6 @@ public function getLocalDefinition()
                           'debug',
                           Builder::start()
                                  ->addBoolean('disableParentRecords', false)
-                                 ->addBoolean('showForeignKeyFingerprint', false)
                                  ->addBoolean('showRecordDepth', false)
                                  ->addBoolean('showExecutionTime', true)
                                  ->addBoolean('allInformation', false)

Classes/Config/Definer/SshConnectionDefiner.php

@@ -64,6 +64,11 @@ public function getLocalDefinition()
                                  ->addString('foreignKeyFingerprintHashingMethod', 'SSH2_FINGERPRINT_MD5')
                                  ->addBoolean('ignoreChmodFail', false)
                       )
+                      ->addArray(
+                          'debug',
+                          Builder::start()
+                                 ->addBoolean('showForeignKeyFingerprint', false)
+                      )
                       ->end();
     }
 

Classes/Controller/FrontendController.php

@@ -49,7 +49,7 @@ class FrontendController extends AbstractController
      */
     public function previewAction($identifier = 1)
     {
-        $this->view->assign('local_preview', BackendUtility::buildPreviewUri('pages', $identifier, 'local'));
-        $this->view->assign('foreign_preview', BackendUtility::buildPreviewUri('pages', $identifier, 'foreign'));
+        $this->view->assign('local_preview', (string)BackendUtility::buildPreviewUri('pages', $identifier, 'local'));
+        $this->view->assign('foreign_preview', (string)BackendUtility::buildPreviewUri('pages', $identifier, 'foreign'));
     }
 }

Classes/Controller/RedirectController.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+namespace In2code\In2publishCore\Controller;
+
+/*
+ * Copyright notice
+ *
+ * (c) 2021 in2code.de and the following authors:
+ * Oliver Eglseder <[email protected]>
+ *
+ * All rights reserved
+ *
+ * This script is part of the TYPO3 project. The TYPO3 project is
+ * free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * The GNU General Public License can be found at
+ * http://www.gnu.org/copyleft/gpl.html.
+ *
+ * This script is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * This copyright notice MUST APPEAR in all copies of the script!
+ */
+
+class RedirectController extends \In2code\In2publishCore\Features\RedirectsSupport\Controller\RedirectController
+{
+}

Classes/Domain/Factory/RecordFactory.php

@@ -38,6 +38,7 @@
 use In2code\In2publishCore\Service\Configuration\TcaService;
 use TYPO3\CMS\Core\Log\Logger;
 use TYPO3\CMS\Core\Log\LogManager;
+use TYPO3\CMS\Core\SingletonInterface;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Extbase\SignalSlot\Dispatcher;
 use TYPO3\CMS\Extbase\SignalSlot\Exception\InvalidSlotException;
@@ -59,7 +60,7 @@
  * records and any of the related records related records and so on to the extend
  * of the setting maximumRecursionDepth
  */
-class RecordFactory
+class RecordFactory implements SingletonInterface
 {
     public const DEPRECATION_METHOD_NO_TABLE_ARG = 'Calling %s without tableName is deprecated. tableName will be a non-optional argument in in2publish_core version 10.';
 
@@ -342,6 +343,13 @@ protected function findRelatedRecordsForContentRecord(
             $this->findTranslations($record, $commonRepository);
 
             $record = $commonRepository->enrichRecordWithRelatedRecords($record, $excludedTableNames);
+
+            $this->signalSlotDispatcher->dispatch(
+                RecordFactory::class,
+                'addAdditionalRelatedRecords',
+                [$record, $this]
+            );
+
             $this->relatedRecordsDepth--;
         }
         return $record;

Classes/Domain/Model/Record.php

@@ -502,6 +502,17 @@ public function setDirtyProperties(): RecordInterface
         return $this;
     }
 
+    /**
+     * @param RecordInterface $record
+     * @return bool
+     */
+    public function isTranslationOriginal(RecordInterface $record): bool
+    {
+        $tcaService = GeneralUtility::makeInstance(TcaService::class);
+        $pointerField = $tcaService->getTransOrigPointerField($this->getTableName());
+        return !empty($pointerField) && $record->getIdentifier() === $this->getMergedProperty($pointerField);
+    }
+
     /**
      * @param string $propertyName
      *
@@ -653,6 +664,7 @@ public function addRelatedRecord(RecordInterface $record)
                 // beneath its new parent anyway.
                 if (!($this->isPagesTable() && $record->isPagesTable())
                     || $record->getSuperordinatePageIdentifier() === $this->getIdentifier()
+                    || $this->isTranslationOriginal($record)
                 ) {
                     if (!$this->isParentDisabled) {
                         $record->setParentRecord($this);

Classes/Domain/Repository/BaseRepository.php

@@ -38,6 +38,8 @@
 use TYPO3\CMS\Core\Log\LogManager;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
+use TYPO3\CMS\Core\Utility\MathUtility;
+
 use function array_column;
 use function array_combine;
 use function explode;
@@ -154,10 +156,20 @@ protected function findPropertiesByProperty(
         }
 
         $query = $connection->createQueryBuilder();
+
+        if (is_array($propertyValue)) {
+            foreach ($propertyValue as $idx => $value) {
+                $propertyValue[$idx] = $query->getConnection()->quote($value);
+            }
+            $constraint = $query->expr()->in($propertyName, $propertyValue);
+        } else {
+            $constraint = $query->expr()->like($propertyName, $query->createNamedParameter($propertyValue));
+        }
+
         $query->getRestrictions()->removeAll();
         $query->select('*')
               ->from($tableName)
-              ->where($query->expr()->like($propertyName, $query->createNamedParameter($propertyValue)));
+              ->where($constraint);
         if (!empty($additionalWhere)) {
             $query->andWhere($additionalWhere);
         }
@@ -184,10 +196,9 @@ protected function findPropertiesByProperty(
                 $propertyArray[implode(',', $identifierArray)] = $row;
             }
             return $propertyArray;
-        } else {
-            foreach ($rows as $row) {
-                $propertyArray[$row[$indexField]] = $row;
-            }
+        }
+        foreach ($rows as $row) {
+            $propertyArray[$row[$indexField]] = $row;
         }
 
         return $propertyArray;
@@ -233,7 +244,11 @@ public function findPropertiesByProperties(
         }
 
         foreach ($properties as $propertyName => $propertyValue) {
-            $query->andWhere($query->expr()->like($propertyName, $query->createNamedParameter($propertyValue)));
+            if (null === $propertyValue) {
+                $query->andWhere($query->expr()->isNull($propertyName));
+            } else {
+                $query->andWhere($query->expr()->like($propertyName, $query->createNamedParameter($propertyValue)));
+            }
         }
 
         if (!empty($groupBy)) {