[BUGFIX] Fixes "never reached localized form record UID" bug. #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If localized form record exists BackendUtilityCore::getRecordLocalization method will return array with one element which is an array of localized form data. Not the array of form data directly. This fix solves the bug by fetching the first element in array and then get the UID of localized record.
einpraegsam
force-pushed
the
develop
branch
4 times, most recently
from
a31ca4e to
43b5957
Compare
|
I cannot see an issue here. Tested with TYPO3 v12 and EXT:powermail v.12.4.1 If you think, that it is still an issue, please re-open it and provide more info and an updated PR Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If localized form record exists BackendUtilityCore::getRecordLocalization method will return array with one element which is an array of localized form data. Not the array of form data directly.
This fix solves the bug by fetching the first element in array and then get the UID of localized record.
$row is renamed to $results here. So, it should be "$results[0]['uid']" rather then "$results['uid']".