[BUGFIX] Use type="number" for validation min and max #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description at https://github.com/einpraegsam/powermail/blob/develop/Documentation/ForEditors/FieldInput.md#validation says 'No HTML5 type - type="text" is used' but 'number' is the correct type. Also the note for email and url is wrong. There is a HTML type
ste101
changed the title
einpraegsam
force-pushed
the
develop
branch
4 times, most recently
from
a31ca4e to
43b5957
Compare
mschwemer
changed the title
mschwemer
pushed a commit
that referenced
this pull request
Sep 25, 2024
mschwemer
pushed a commit
that referenced
this pull request
Sep 25, 2024
|
Merged it using a new PR, due to the age of the PR. You are still the author :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description at https://github.com/einpraegsam/powermail/blob/develop/Documentation/ForEditors/FieldInput.md#validation says 'No HTML5 type - type="text" is used' but 'number' is the correct type.
Also the note for email and url is wrong. There is a HTML type