Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][TASK] Make prefill work when a request is not cached, but caching is enabled #826

Closed
wants to merge 1 commit into from

Conversation

pschriner
Copy link

Prefill cannot be used when caching is enabled even when it is safe to do so (because an action is called that is uncached).
This patch allowes using prefill when caching is enabled (good for situations with EXT:sfc & powermail forms that are included via Typoscript)

@mschwemer mschwemer deleted the branch in2code-de:develop December 28, 2023 10:19
@mschwemer mschwemer closed this Dec 28, 2023
@mschwemer mschwemer reopened this Dec 28, 2023
@mschwemer
Copy link
Collaborator

Hi Patrick

Thanks for your contribution. I am sorry to decline your PR. Why?

My / our main concern is, that there might be the possibility that user contributed data gets cached. Only with the TYPO3 core it will probably work. But you never don't know what people do and how they hack the caching stuff. ;-)

If there is any issue, this will fall back to powermail and we will have to test, argue and so on ... even if that is not reproducable in a standard installation.

As this works for you, you can still apply this via composer patches for example.

@mschwemer mschwemer closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants