Skip to content

Fix #627: Add SAFE to CI#630

Merged
elbrujohalcon merged 4 commits into
mainfrom
brujo.627.safe
May 19, 2026
Merged

Fix #627: Add SAFE to CI#630
elbrujohalcon merged 4 commits into
mainfrom
brujo.627.safe

Conversation

@elbrujohalcon

Copy link
Copy Markdown
Member

Description

Add SAFE to our CI pipelines.

Closes #627.

@elbrujohalcon elbrujohalcon self-assigned this May 15, 2026
@elbrujohalcon elbrujohalcon added this to the 5.0.4 milestone May 15, 2026
@elbrujohalcon elbrujohalcon force-pushed the brujo.627.safe branch 3 times, most recently from 9e9cdb2 to 0d7389b Compare May 15, 2026 17:39
@elbrujohalcon elbrujohalcon force-pushed the brujo.627.safe branch 2 times, most recently from 78eb552 to 9bb2896 Compare May 19, 2026 11:52
@elbrujohalcon

Copy link
Copy Markdown
Member Author

We're safe now, @paulo-ferraz-oliveira @bormilan @NelsonVides !!

@bormilan bormilan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we should make an issue to fix the problematic lines that you ignored now.

@elbrujohalcon

elbrujohalcon commented May 19, 2026

Copy link
Copy Markdown
Member Author

Nice! I think we should make an issue to fix the problematic lines that you ignored now.

I don't think so. I reviewed each one of them and they are, in fact, safe... Even when using functions that can be abused, we know that they are not.

The calls to list_to_atom come from parsing Erlang modules that are not compiled. So, those atoms 100% not existing, but we do want to create them for our analysis.
The calls to file:consult/1 are needed in order to analyse config files and such... We could, in theory, check the size or whatever attribute from those files before running file:consult/1 on them... but... we'd end up calling file:consult/1, anyway... and I'm pretty sure that SAFE doesn't know if we checked the files before calling the function.

So... unavoidable ignores, all of them.

@elbrujohalcon elbrujohalcon merged commit de041f6 into main May 19, 2026
8 checks passed
@elbrujohalcon elbrujohalcon deleted the brujo.627.safe branch May 19, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SAFE to CI

2 participants