Conversation
|
I tested the grant ID in this PR and it works. |
|
@ThierryO I need to publish some reports for B-Cubed by the end of February. Can you please look at this asap? It would save me a lot of manual labour @ElsLommelen you should be able to use the publisher role to add INBO as publisher in Zenodo |
|
It works fine if I add the publisher manually in DESCRIPTION, and I don't mind updating it like this for existing packages, but could this possibly be added automatically (or after asking a question) when starting a new package? Otherwise I will surely forgot it several times (unless it is in the manual). As it is mandatory or strongly recommended (?), I think everyone wants to have it added with a minimal of effort. |
ThierryO
left a comment
There was a problem hiding this comment.
We need to document this new feature somewhere.
A few more things to do:
- projects should have these features too
- organisations should be able to enforce the publisher
Make at least an issue if you can do that in the short run.
R/citation_meta_class.R
Outdated
| grant_id <- grant_id[!is.na(grant_id)] | ||
|
|
||
| if (length(grant_id) > 0) { | ||
| stopifnot("Only single grant ID possible" = length(grant_id) == 1) |
There was a problem hiding this comment.
Please check that Zenodo allows only a single grant before enforcing this.
There was a problem hiding this comment.
It can be an array (ref). I will fix this.
Co-authored-by: Thierry Onkelinx <ThierryO@users.noreply.github.com>
|
I have made the suggested changes:
This PR is a working fix for #180 and #183
Next week I will discuss this topic at the Open Science Helphub with the datastewards. Is this fine for you? @ThierryO can you also fix #184 in this PR? Or is this more complicated than it looks? |
.zenodo.jsonSupport EU Open Research Repository funding zenodo metadata via DESCRIPTION (role = "fnd") #182Example:
grant_id = "283595"(European Commission grants only) or funder DOI-prefixed:grant_id = "10.13039/501100000780::283595"(All grants, recommended) (ref).zenodo.jsonAdd publisher to Zenodo? #180