Retrigger tests with cast removed from nidmresults library - #488
Open
cmaumet wants to merge 6 commits into
Open
Conversation
cmaumet
changed the title
cmaumet
changed the title
Member
Author
|
@khelm: the tests pass although we do get some missing links -- e.g. to 'Map' in |
Contributor
|
Thanks @cmaumet - any idea why Map doesn't show up? This issue arose because there are evidently some non-printing unicode characters in the files that I've been working to eliminate, with only partial success. |
Member
Author
|
@khelm - I think the terms that do not show up are those that are used inside a definition (and were surrounded by quotes so that they would be picked up as terms). Do you have an example of where the cast is making the tests fail on nidm-experiment updates? Is #487 a good example? Or should I be looking somewhere else? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a companion PR to incf-nidash/nidmresults#59. To retrigger the tests and check that removing the cast as suggested by @khelm does not cause backward compatibility issues.