Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a shutdown bug in the stdio transport where
Ctrl-Ccould log graceful shutdown but leave the MCP server running indefinitely. The process now exits promptly when cancellation is requested.The issue was that shutdown depended on a blocking stdin decode loop. If stdin was idle, the server could not observe context cancellation, so it never completed shutdown after receiving
SIGINT/SIGTERM.This change decouples decoding from the shutdown path so cancellation is always observable, even when reads are blocked. It also treats
context.Canceledas a normal stop inmain, and adds regression tests that reproduce blocked-reader scenarios and assert clean termination.Tested with
go test ./....