create incident catalog entry attribute#218
Open
crockeo wants to merge 2 commits intoincident-io:masterfrom
Open
create incident catalog entry attribute#218crockeo wants to merge 2 commits intoincident-io:masterfrom
crockeo wants to merge 2 commits intoincident-io:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a new resource type,
incident_catalog_entry_attributewhich can be used to assign a single attribute to an Incident.io catalog entry.Example usage:
This form allows you to manage a catalog entry and its attributes separately, which means:
count = <condition> : 1 ? 0, rather than conditionally populating elements in array).catalog1andcatalog2have attributes which reference each other. Currently, that produces a cycle at TF plan time. In this formulation you can provisioncatalog1,catalog2, and their attributes such that they don't have a cycle.Note that this architecture is used elsewhere in the TF ecosyste, for example AWS once suggested developer use
ingressandegresson theaws_security_groupresource, but now they suggest that developers create separate resources, much in the same way.Note that this creates a sharp edge, where one could accidentally try to manage a catalog entry attribute through both
incident_catalog_entryandincident_catalog_entry_attribute. I don't know a great solution to this w/o a backwards incompatible change.