Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for megatron-bridge as an alternative to mbridge for creating Megatron models. This is controlled by a new bridge_type configuration parameter. The changes correctly adapt model creation, saving, and loading logic based on the selected bridge. The implementation looks solid, but I have a few suggestions to improve code quality by removing a debug print statement and refactoring some duplicated and repetitive code blocks.
|
Hi @gursimar , thanks for the contribution, but IMO the current form has several issues that should be addressed:
|
7ec6c3b to
f49f94b
Compare
|
@garrett4wade Using Qwen3-0.6B (TP=1, PP=1)
Using Qwen2.5-14B-Instruct (TP=1, PP=1)
megatron-bridge seems to have slightly poor save/load times. I think its better that we address the optimized save/load in a separate, future PR. Script: benchmark_bridges.py Let me know if something else needs to be addressed for merging this PR. |
- tested TP,PP>1 megatron-bridge integration with mbridge backward compatibility - darwin with x86_64 needs special handling as torch >2.9.1 stops support - some packages conflicts due to megatron-bridge are overridden to previous versions
f49f94b to
da01bc4
Compare






Description
First PR for the adaptation of Megatron-Bridge into AReaL. See RFC #1055 for more details.
Implementation details
1. Introduced a new parameter whose default value is mbridge. So it will not break/ change flow of existing code
2. Implemented megatron-bridge model creation when bridge_type=megatron-bridge
3. Testing
4. Resolved dependency conflicts
5. Added docs pages
Type of Change
Checklist
pre-commit run --all-files)./docs/build_all.sh)main/review-prcommand/create-prBreaking Change Details (if applicable):
No Breaking change, in fact it is backward compatible
Additional Context
Need help? Check the Contributing Guide or ask in
GitHub Discussions!