terminal tool timeout env

[kevinfeng030]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility of the terminal tool by enabling its execution timeout to be configured dynamically through an environment variable. This change allows operators to adjust timeout settings without modifying the codebase, improving adaptability in various deployment environments.

Highlights

• Environment Variable for Timeout: Introduced the TERMINAL_TIMEOUT environment variable, allowing it to override the default or parameter-specified timeout for terminal tool execution.
• Robust Timeout Handling: Implemented error handling to gracefully manage cases where the TERMINAL_TIMEOUT environment variable is set but contains a non-integer value, ensuring the existing timeout remains unchanged.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• aworld/sandbox/tool_servers/terminal/src/terminal.py
  • Added support for overriding the timeout parameter using the TERMINAL_TIMEOUT environment variable.
  • Included error handling for invalid TERMINAL_TIMEOUT environment variable values.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces the ability to override the terminal command timeout via the TERMINAL_TIMEOUT environment variable. The implementation is straightforward, but I've identified a potential issue where a negative timeout value could be set, leading to undefined behavior. I've provided a suggestion to ensure the timeout value is always non-negative.

[gemini-code-assist]

The current implementation allows for a negative timeout if TERMINAL_TIMEOUT is set to a negative number. This can lead to undefined behavior in asyncio.wait_for, which expects a non-negative value for the timeout. It's better to validate that the timeout is non-negative before assigning it.

Suggested change

	timeout = int(env_timeout)
	parsed_timeout = int(env_timeout)
	if parsed_timeout >= 0:
	timeout = parsed_timeout