feat: add new resources#794
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds new resource references and updates locale entries for various consumer actions.
- Removed the “pompe-chaleur” resource and replaced it with updated resource IDs and links
- Added 11 new locale keys in each language (e.g.,
agir-livraison,gagner-place, etc.) - Extended
overScreenCategoryValueswith additional category-specific resource blocks
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/providers/locales/fr.json | Added new French keys and removed pompe-chaleur |
| src/providers/locales/es.json | Added new Spanish keys and removed pompe-chaleur |
| src/providers/locales/en.json | Added new English keys and removed pompe-chaleur |
| src/components/shareable/overScreens/Values/Category.tsx | Expanded overScreenCategoryValues with resource blocks per category |
| src/components/shareable/overScreens/Values/OsezChanger.tsx | Updated two resource links/images |
Comments suppressed due to low confidence (4)
src/providers/locales/fr.json:565
- [nitpick] The locale key 'epargnonsnosressources' is inconsistent with other keys that use hyphens. Consider renaming it to 'epargnons-nos-ressources' for naming consistency.
"epargnonsnosressources": "Évaluer votre besoin réel avant d’acheter",
src/providers/locales/es.json:565
- [nitpick] The locale key 'epargnonsnosressources' in Spanish is inconsistent with other keys that use hyphens. Consider renaming it to 'epargnons-nos-ressources' for consistency across languages.
"epargnonsnosressources": "Evalúa tu necesidad real antes de comprar",
src/providers/locales/en.json:565
- [nitpick] The locale key 'epargnonsnosressources' in English is inconsistent with other keys that use hyphens. Consider renaming it to 'epargnons-nos-ressources' (or a suitable English equivalent) for consistency.
"epargnonsnosressources": "Assess your real need before buying",
src/components/shareable/overScreens/Values/Category.tsx:407
- New branches for
category.slugvalues like 'repas', 'boisson', etc., should be accompanied by unit tests to verify that the correct resources render for each category.
if (category.slug === 'repas') {
| }, | ||
| } | ||
| } | ||
| if (category.slug === 'repas') { |
There was a problem hiding this comment.
The overScreenCategoryValues function has grown large with repeated conditional blocks. Consider extracting resource definitions into a configuration map or separate data structure to reduce duplication and improve readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.