chore: use pnpmx and limit github permissions#824
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances security and standardizes package execution by replacing npx with pnpx across build scripts and implementing the principle of least privilege in GitHub Actions workflows.
Key Changes:
- Standardized all npm package execution commands to use
pnpxinstead ofnpxfor consistency with the pnpm package manager - Added explicit read-only permissions to GitHub Actions workflows to limit access scope
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Updated build and test scripts to use pnpx instead of npx for Prisma, Playwright, and tsx execution |
| .github/workflows/iframes.yml | Added read-only permissions for contents and pull-requests |
| .github/workflows/e2e.yml | Added read-only permissions for contents and pull-requests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d4a6465 to
c117830
Compare
|
@lsagetlethias I've opened a new pull request, #825, to work on those changes. Once the pull request is ready, I'll request review from you. |
lsagetlethias
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.