Skip to content

fix: accessibility in etiquette#876

Merged
desoindx merged 1 commit into
developfrom
fix/accessibility
Apr 7, 2026
Merged

fix: accessibility in etiquette#876
desoindx merged 1 commit into
developfrom
fix/accessibility

Conversation

@desoindx
Copy link
Copy Markdown
Contributor

@desoindx desoindx commented Apr 7, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 7, 2026 12:38
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR targets accessibility improvements for the “etiquette” (Shopify external module), and tightens CI accessibility expectations.

Changes:

  • Increased the clickable size (padding/height) of the Progress and Disclaimer icon buttons.
  • Conditionally removed the Disclaimer UI when the randomize button is present in the inline etiquette.
  • Raised the Lighthouse accessibility score threshold in the E2E workflow.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/components/externalModules/shopify/Progress.module.css Enlarges the Progress control button sizing to improve tap/target size.
src/components/externalModules/shopify/Equivalent.tsx Hides Disclaimer when randomize is provided (inline etiquette path).
src/components/externalModules/shopify/Disclaimer.module.css Enlarges the Disclaimer control button sizing to improve tap/target size.
.github/workflows/e2e.yml Raises Lighthouse minAccessibilityScore threshold to 100.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +91 to +102
{
// On n'affiche le dislaimer que si il n'y a pas le bouton randomize, pour des soucis d'accessibilité
// Aujourd'hui c'est juste sur le site donc pas de soucis. A voir comment on fera plus tard
!randomize && (
<Disclaimer
language={language}
comparisons={comparisons}
baseValue={preciseValue}
id={animated ? 'animated' : 'static'}
/>
)
}
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally removing the when randomize is provided changes the feature set of the inline “etiquette”: users lose access to the content/info panel in the randomized variant, while the column variant (ColumnEquivalent) still shows the disclaimer even when randomize exists. If the goal is to resolve an accessibility issue (e.g. overlapping controls or an ARIA relationship problem), it’d be better to fix that underlying issue while keeping the disclaimer available, and keep behavior consistent between inline/column renderings.

Suggested change
{
// On n'affiche le dislaimer que si il n'y a pas le bouton randomize, pour des soucis d'accessibilité
// Aujourd'hui c'est juste sur le site donc pas de soucis. A voir comment on fera plus tard
!randomize && (
<Disclaimer
language={language}
comparisons={comparisons}
baseValue={preciseValue}
id={animated ? 'animated' : 'static'}
/>
)
}
<Disclaimer
language={language}
comparisons={comparisons}
baseValue={preciseValue}
id={animated ? 'animated' : 'static'}
/>

Copilot uses AI. Check for mistakes.
Comment on lines +92 to +93
// On n'affiche le dislaimer que si il n'y a pas le bouton randomize, pour des soucis d'accessibilité
// Aujourd'hui c'est juste sur le site donc pas de soucis. A voir comment on fera plus tard
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new inline comment has spelling/grammar issues (“dislaimer”, “si il”, etc.) and reads like a temporary rationale (“pas de soucis… plus tard”) rather than actionable documentation. Please correct the wording (or replace with a proper TODO linked to an issue) so future maintainers understand the concrete accessibility constraint being addressed.

Suggested change
// On n'affiche le dislaimer que si il n'y a pas le bouton randomize, pour des soucis d'accessibilité
// Aujourd'hui c'est juste sur le site donc pas de soucis. A voir comment on fera plus tard
// N'afficher le disclaimer que lorsqu'il n'y a pas de bouton de randomisation,
// afin d'éviter un problème d'accessibilité lorsque les deux éléments sont présents.

Copilot uses AI. Check for mistakes.
@desoindx desoindx force-pushed the fix/accessibility branch 3 times, most recently from b7aa64d to b6eda94 Compare April 7, 2026 14:50
@desoindx desoindx force-pushed the fix/accessibility branch from b6eda94 to 355b0eb Compare April 7, 2026 15:10
@desoindx desoindx merged commit 630f854 into develop Apr 7, 2026
6 checks passed
@desoindx desoindx deleted the fix/accessibility branch April 7, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants