Add imagePullSecrets change #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paretl
force-pushed
the
add-imagePullSecrets
branch
from
7260b73 to
fc45cff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a need that we currently have, this PR adds the modification of the
imagePullSecretsof a pod where an image have been updated. It permits to avoid adding (or missing 😄) this secret on all the releases/deployments of a kube cluster using the harbor mutating webhookIt adds the boolean parameter
replaceImagePullSecretsin the configuration which will be used withauthSecretNameto add this secret to theimagePullSecretsof the pod. To avoid any errors, it keep the existing secrets that are already inimagePullSecretsand only adds the new one.I'm not a Go expert, so feel free to give me feedbacks and improvements that can be made on the code.
#52