IWF-405: Rename failure handling API #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longquanzheng
commented
Dec 10, 2024
| workflow_id, "", type_hint | ||
| ) | ||
|
|
||
| def wait_for_workflow_completion( |
There was a problem hiding this comment.
this is also a rename same as in Java SDK.. too lazy to open a ticket for that (🥹 )https://github.com/indeedeng/iwf-java-sdk/blob/main/src/main/java/io/iworkflow/core/Client.java#L339
longquanzheng
requested review from
lwolczynski,
ktrops,
samuel27m and
stevo89519
longquanzheng
commented
Dec 10, 2024
iwf/workflow_state_options.py
Outdated
| """ | ||
| execute_failure_handling_state: Optional[type] = None | ||
| execute_failure_handling_state_when_retry_exhausted: Optional[type] = None |
There was a problem hiding this comment.
NOTE: python uses a different pattern as we mentioned this morning. we have wrapped a higher level model on the workflow state.
longquanzheng
changed the title
lwolczynski
reviewed
Dec 10, 2024
iwf/workflow_state_options.py
Outdated
| @@ -87,14 +114,25 @@ def _to_idl_state_options( | |||
| res.execute_api_retry_policy = options.execute_api_retry_policy | |||
| if options.execute_api_timeout_seconds is not None: | |||
| res.execute_api_timeout_seconds = options.execute_api_timeout_seconds | |||
| if options.execute_failure_handling_state is not None: | |||
| if options.execute_failure_handling_state_when_retry_exhausted is not None: | |||
There was a problem hiding this comment.
Should we make the naming more consistent like in the JavaSDK?
wait_until_api_failure_policy_when_retry_exhausted
execute_api_failure_policy_when_retry_exhausted
?
There was a problem hiding this comment.
yeah I am thinking on that too. We can't do exactly because python sdk is using a differetn model and Python don't use the same convention like Java.
Maybe:
- proceed_to_state_when_execute_retry_exhausted : state_class
- proceed_to_execute_when_wait_until_retry_exhausted: bool
Our java SDK is :
- setProceedWhenExecuteRetryExhausted
- setProceedWhenWaitUntilRetryExhausted
WDYT?
lwolczynski
approved these changes
Dec 11, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.