mcp: document register_resource usage + overlay + self-contained HTML#1335
Merged
Merged
Conversation
… self-contained HTML)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
AI review found issues in this pull request.
Verdict: patch is incorrect
Confidence: 0.90
The patch is documentation-only, but it introduces materially incorrect API guidance about sandboxed resource panes and external CDN loading.
- P2
packages/mcp/ix_notebook_mcp/runtime.py:827Misleading docs say CDN scripts/styles are blocked
Contributor
Blast radius
pie showData title Rebuilt checks by category
"rust" : 41
"image" : 15
"site" : 2
"agent" : 1
"blast" : 1
"eval" : 1
"lint" : 1
flowchart LR
c0["ix-notebook-mcp-module"]
c1["blast-radius-test"]
c2["agent-skills"]
c3["lint"]
c4["rust-mcp.viewSmoke"]
c5["site-test"]
c0 --> k0["agent-skills"]
c0 --> k2["eval"]
c0 --> k3["image-development-base"]
c0 --> k4["image-kernel-dev"]
c0 --> k5["image-minecraft"]
changed checks (62)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Expand the
register_resourcedocstring (surfaced viaapi()/help()) to cover how to use it properly:idreplaces in place (a loop updating one view) vs. a random id spawning a new pane each call.renderis re-invoked on refresh (contrast withcells).alivepredicate auto-closes the resource.nix run .#ix-windowsrenders each live resource as a floating, blurred, auto-sizing window (drag by the chrome, not resizable).allow-scripts, noallow-same-origin) in both the dashboard and the overlay, so inline all CSS/JS/data; pre-render anything needing a library (e.g. mermaid -> SVG via kroki/CLI), since CDN scripts silently fail.Docstring-only; parses clean, lines ≤88.
🤖 Authored with Claude Code (Opus).
Note
Document
register_resourceusage with overlay, iframe, and self-contained HTML guidanceExpands the docstring for
register_resourcein runtime.py with structured documentation covering argument behaviors, stable ID guidance, auto-closing semantics, overlay window rendering via ix-windows, iframe sandboxing and origin constraints, and a recommendation to prefer self-contained HTML for external asset compatibility. No executable code changes.Macroscope summarized 8a4e94f.