Add Extended Affiliations plugin#2
Conversation
duartegalvao
force-pushed
the
affiliations
branch
2 times, most recently
from
5227390 to
2c79285
Compare
duartegalvao
force-pushed
the
affiliations
branch
10 times, most recently
from
b89aaec to
7aa56af
Compare
duartegalvao
force-pushed
the
affiliations
branch
from
7aa56af to
7b2cea7
Compare
| } | ||
|
|
||
| return ( | ||
| <div styleName="items-column-container"> |
There was a problem hiding this comment.
I guess that the Semantic UI Table component doesn't look good here (or it doesn't fit altogether)?
There was a problem hiding this comment.
why a table for a tags display? inside of another table no less 😄
There was a problem hiding this comment.
If we had alread the datatable widget in Indico, we could avoid ALL of this filtering logic. 😮💨🌈
duartegalvao
force-pushed
the
affiliations
branch
4 times, most recently
from
e4fb5dc to
5d7cba6
Compare
duartegalvao
changed the title
duartegalvao
force-pushed
the
affiliations
branch
from
5d7cba6 to
c0fe39d
Compare
duartegalvao
force-pushed
the
affiliations
branch
4 times, most recently
from
84426f1 to
860a914
Compare
|
Ah and this repo now also uses ruff's isort implementation and the ruff formatter, so after rebasing I recommend running both |
|
Actually I took care of rebasing and formatting since it was a good opportunity to tweak the formatter config, but please fix the other comments. |
hatchling does not need this
all done! speaking of formatters, it would also be nice to add biomejs to this repo (i've used it already for this plugin but had to add my own config file) |
|
I completely agree, I just didn't have the motivation to do so yet (and we don't do that much plugin development for it to be urgent) |
4 participants
This PR adds the Extended Affiliations plugin.
Currently set to draft while we are performing our own reviews, but it is fully functional.