Skip to content

fix some uninitialized variables warnings#619

Open
timsurber wants to merge 1 commit into
indigo-astronomy:masterfrom
timsurber:warnings
Open

fix some uninitialized variables warnings#619
timsurber wants to merge 1 commit into
indigo-astronomy:masterfrom
timsurber:warnings

Conversation

@timsurber
Copy link
Copy Markdown
Contributor

This fixes the majority of -Wmaybe-uninitialized warnings in gcc.

@polakovic
Copy link
Copy Markdown
Member

Hi, these changes are generally useful, but since we’re working on a large-scale change (the windows_migration branch), we’re silencing warnings produced not just by GCC but also by MSVC. This makes continuous synchronization with the master branch more complicated. 😞

Please postpone warning silencing until we merge windows_migration into master. After that, it will be warmly welcomed!

@timsurber
Copy link
Copy Markdown
Contributor Author

@polakovic What is the state of these PRs?
they still should be relevant.

@polakovic
Copy link
Copy Markdown
Member

see "windows_migration" branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants