Adding gform styling - #2
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds custom styling for Gravity Forms footer buttons to match theme colors and hover behavior. State diagram for Gravity Forms footer button stylingstateDiagram-v2
[*] --> Normal
Normal: Normal_state
Normal: background #a9325a
Normal: text_color #ffffff
Normal: border 2px_solid_#a9325a
Normal: border_radius 0
Normal --> Hover: mouse_over
Hover --> Normal: mouse_out
Hover: Hover_state
Hover: background transparent
Hover: text_color #a9325a
Hover: border 2px_solid_#a9325a
Hover: border_radius 0
Normal --> [*]: form_unloaded
Hover --> [*]: form_unloaded
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
LukeGohegan
approved these changes
Mar 3, 2026
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new Gravity Forms button styles rely heavily on
!important; consider increasing selector specificity or adjusting the cascade instead so these rules don’t become difficult to override later. - These styles apply globally to all
.gform_wrapperfooters; if the intent is to style only specific forms, consider scoping the selectors to a more specific parent to avoid unintended side effects on other forms. - You’ve added hover styles but no explicit focus/active states; consider adding accessible
:focus-visible(and possibly:active) styles so keyboard users get a clear focus indication consistent with the new design.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new Gravity Forms button styles rely heavily on `!important`; consider increasing selector specificity or adjusting the cascade instead so these rules don’t become difficult to override later.
- These styles apply globally to all `.gform_wrapper` footers; if the intent is to style only specific forms, consider scoping the selectors to a more specific parent to avoid unintended side effects on other forms.
- You’ve added hover styles but no explicit focus/active states; consider adding accessible `:focus-visible` (and possibly `:active`) styles so keyboard users get a clear focus indication consistent with the new design.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Align Gravity Forms button styling with the site's primary brand colours.
New Features:
Enhancements: