Skip to content

Development changes - #7

Merged
paulgibbs merged 2 commits into
mainfrom
feature/development-changes
Mar 5, 2026
Merged

Development changes#7
paulgibbs merged 2 commits into
mainfrom
feature/development-changes

Conversation

@yasminosten13

@yasminosten13 yasminosten13 commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Updating header and button colours

Summary by Sourcery

Adjust header layout spacing and update button styling to use theme color variables for rose bloom, including hover states.

Enhancements:

  • Simplify the header structure by removing the unused top bar and adjusting padding around the logo and main navigation.
  • Align Gravity Forms button colors with the theme's custom rose bloom color preset and ensure hover states use the same variable-based color system.
  • Apply consistent hover color styling for generic block buttons using the rose bloom preset color.

@sourcery-ai

sourcery-ai Bot commented Mar 5, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refines the global header layout/padding and aligns Gravity Forms and button hover colors with the theme’s rose-bloom color preset.

File-Level Changes

Change Details Files
Simplified header structure and adjusted spacing to use consistent padding around the logo and main navigation.
  • Removed the unused top-bar header group that only provided an empty secondary area on desktop/tablet.
  • Promoted the logo/main navigation group to be the primary header content directly under the sticky header wrapper.
  • Updated header padding to use theme spacing preset xx-small on all sides instead of zero padding.
  • Simplified inner header group configuration by removing extra padding and leaving only blockGap control on the wide container.
wp-content/themes/indigotree-theme-2025/parts/header.html
Switched Gravity Forms button styling and generic button hover text to use a theme color preset instead of a hard-coded hex value.
  • Replaced hard-coded #a9325a background and border colors on Gravity Forms buttons with var(--wp--preset--color--custom-rose-bloom).
  • Updated Gravity Forms button hover text color to use the same custom-rose-bloom preset instead of the hex color.
  • Added a .wp-block-button__link:hover rule so Gutenberg buttons change text color to the custom-rose-bloom preset on hover.
wp-content/themes/indigotree-theme-2025/assets/sass/main.css

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new .wp-block-button__link:hover rule with !important will apply globally to all buttons and may override context-specific styles; consider scoping it to a more specific container or button variant if the intent is limited to certain areas.
  • Removing the top bar group from the header layout changes the structure and classes used for secondary navigation/search/language; double-check whether any JavaScript or CSS elsewhere relies on those removed selectors (site-header__top, visibility classes) and adjust those references instead of just deleting the block.
  • Using !important on the new color variables for Gravity Forms buttons and hover states makes future theming harder; consider reducing !important usage by increasing selector specificity where needed instead.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `.wp-block-button__link:hover` rule with `!important` will apply globally to all buttons and may override context-specific styles; consider scoping it to a more specific container or button variant if the intent is limited to certain areas.
- Removing the top bar group from the header layout changes the structure and classes used for secondary navigation/search/language; double-check whether any JavaScript or CSS elsewhere relies on those removed selectors (`site-header__top`, visibility classes) and adjust those references instead of just deleting the block.
- Using `!important` on the new color variables for Gravity Forms buttons and hover states makes future theming harder; consider reducing `!important` usage by increasing selector specificity where needed instead.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@paulgibbs
paulgibbs merged commit a1bb148 into main Mar 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants