Button styling changes - #9
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts button-related styles by adding a hover color override for a specific outline button variant and normalizing the font weight for "Read more" buttons. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
:root :where(.wp-block-button.is-style-outline--2 .wp-block-button__link:hover)selector may be more specific than necessary; consider dropping:rootif you don't need the extra specificity so that future overrides remain easier to manage. - If you're changing the hover color for
.is-style-outline--2buttons, consider adding matching:focus/:focus-visiblestates for keyboard users so the interaction remains consistent and accessible.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `:root :where(.wp-block-button.is-style-outline--2 .wp-block-button__link:hover)` selector may be more specific than necessary; consider dropping `:root` if you don't need the extra specificity so that future overrides remain easier to manage.
- If you're changing the hover color for `.is-style-outline--2` buttons, consider adding matching `:focus`/`:focus-visible` states for keyboard users so the interaction remains consistent and accessible.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
LukeGohegan
previously approved these changes
Mar 6, 2026
LukeGohegan
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Adjust button styling for outline button hover state and refine read-more button typography.
Enhancements: