fix buffer overflow error found with Celestron focuser#2252
Merged
Conversation
Contributor
|
Thank you! |
Contributor
Author
|
@knro - turns out the changes works for x86_64 but for my Manjaro aarch64 it still is an issue. I'll try to hack around over the next few days to find what the issue is. |
knro
pushed a commit
to knro/indi
that referenced
this pull request
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After getting back in to astrophotography I found that my Celestron focuser wasn't working on Linux, both on x86_64 and aarch64. I could see that there was a buffer overflow error detected and traced it down to this 1 line of code. This looks like the issue raised in INDI Forum - driver indi celestron sct . The issue doesn't appear on macOS but definitely on my two different Arch (x86_64 is plain old ArchLinux, ODROID N2+ is Manjaro) based systems
I believe the compilers have been optimising away the size of the
rxbufand then resulted in the buffer oveflow.I've tested this change locally and see that it has resolved the buffer overflow. I can now connect to the focuser and use it.