Skip to content

INDI Focuser driver for Pinefeat Lens Controller#2253

Merged
knro merged 2 commits into
indilib:masterfrom
pinefeat:pinefeat_cef
Jul 10, 2025
Merged

INDI Focuser driver for Pinefeat Lens Controller#2253
knro merged 2 commits into
indilib:masterfrom
pinefeat:pinefeat_cef

Conversation

@pinefeat

@pinefeat pinefeat commented Jul 5, 2025

Copy link
Copy Markdown
Contributor

…apter for Astronomy Camera – Canon® Lens Compatible
@knro

knro commented Jul 6, 2025

Copy link
Copy Markdown
Contributor

Thank you! Can you also add the documentation as per the contributing guidelines?

@pinefeat

pinefeat commented Jul 6, 2025

Copy link
Copy Markdown
Contributor Author

Thank you! Can you also add the documentation as per the contributing guidelines?

@knro Absolutely, the documentation is on the way. Where would you recommend placing the documentation files? The contributing guidelines suggest using a /doc directory, which works well for INDI Third-Party drivers, as each driver resides in its own directory. However, this new driver is part of the core project and is located under /drivers/focuser along with other focusers, none of which have corresponding documentation nearby.

I also noticed that the documentation for existing focusers is available at: https://indilib.org/devices/focusers.html
How can I add documentation for the new driver there? Is that page maintained manually or generated from somewhere?

@s-pouya-sh

Copy link
Copy Markdown
Contributor

@pinefeat the documentation is updated, please check.

@pinefeat pinefeat marked this pull request as ready for review July 10, 2025 07:37
@knro knro merged commit 39698f4 into indilib:master Jul 10, 2025
11 checks passed
knro pushed a commit to knro/indi that referenced this pull request Aug 25, 2025
* added INDI focuser driver for Pinefeat EF / EF-S Lens Controller & Adapter for Astronomy Camera – Canon® Lens Compatible

* added documentation for INDI focuser driver - Pinefeat EF / EF-S Lens Controller & Adapter
@pinefeat pinefeat deleted the pinefeat_cef branch May 17, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants