Fix OnStep Sync() to notify clients immediately via EqNP/NewRaDec, matching base class LX200Telescope::Sync() behavior — prevents ~50s ALIGN_SYNCING stall in KStars/Ekos#2364
Merged
Conversation
…tching base class LX200Telescope::Sync() behavior — prevents ~50s ALIGN_SYNCING stall in KStars/Ekos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Notify clients immediately after successful sync in OnStep driver
The OnStep Sync() override updated currentRA/currentDEC but never called
EqNP.setState(IPS_OK) or NewRaDec(), unlike the base class LX200Telescope::Sync().
This caused INDI clients (e.g. KStars/Ekos) to stall in ALIGN_SYNCING state
waiting for an EQUATORIAL_EOD_COORD property update that only arrived on the
next ReadScopeStatus() poll cycle, introducing delays of up to ~50 seconds.