alignment: guard SPK test target when erfa is not found#2380
Merged
Conversation
libs/alignment/CMakeLists.txt already guards indi_SPK_MathPlugin behind
if(ERFA_FOUND), but test/alignment/CMakeLists.txt was missing the same
guard. It used REQUIRED which caused cmake to fail on systems without erfa,
and unconditionally added SPKMathPlugin sources to test_alignment_plugins.
This fix applies the same optional pattern to the test target.
To verify, remove erfa and reconfigure:
cmake -B build -U "*ERFA*" 2>&1 | grep -i erfa
ninja -C build -t targets all | grep -i mathplugin
SPK targets should not appear in the second command's output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libs/alignment/CMakeLists.txt already guards indi_SPK_MathPlugin behind if(ERFA_FOUND), but test/alignment/CMakeLists.txt was missing the same guard. It used REQUIRED which caused cmake to fail on systems without erfa, and unconditionally added SPKMathPlugin sources to test_alignment_plugins. This fix applies the same optional pattern to the test target.
To verify, remove erfa and reconfigure:
SPK targets should not appear in the second command's output.