Replacing null with no_tap in utils_contrasts #89
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bthirion
reviewed
Apr 23, 2025
| if design_matrix_columns is None: | ||
| return dict([(name, []) for name in contrast_names]) | ||
| con = _elementary_contrasts(design_matrix_columns) | ||
| contrasts = { | ||
| 'specified': con['specified'], | ||
| 'chosen': con['chosen'], | ||
| 'null': con['null'], | ||
| 'no_tap': con['no_tap'], |
There was a problem hiding this comment.
I'm afraid that this is not going to work, since con has the strings in design_matrix_columns as keys.
There was a problem hiding this comment.
I think I addressed this here by renaming the entries of the event files as no_tap.
If I understood correctly, make_paradigm in utils_paradigms takes this file and gets the event info, and so far there are no adjustments needed in the post_process function for this task.
Is this what you meant ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #88.