Add support for rendering template images in SNRHUDButtonCell#10
Open
js wants to merge 3 commits intoindragiek:masterfrom
Open
Add support for rendering template images in SNRHUDButtonCell#10js wants to merge 3 commits intoindragiek:masterfrom
js wants to merge 3 commits intoindragiek:masterfrom
Conversation
Author
|
sigh, actually now that I look at it a bit closer it is a bit on the dark side as there's not much difference between its disabled and enabled state? |
Owner
|
I think we should be relying on NSImageCell to draw template images instead of expecting super to behave the way we want. I think I tested this earlier and ran into some issues, I'll give it another try soon. In the meanwhile you could try investigating that to see if it does a better job :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling super seems to do an OK job of rendering template images, still not sure about other kind of images and the various
imagePosition. Also added a little square button with the builtin NSAddTemplate to the Catalog app.