feat(tests): use logger instead of printing #920
Conversation
| @@ -580,8 +580,7 @@ def test_poisson_fem(ctx_factory): | |||
| J[c] * w[k] * sum(ell, dpsi(i,k,ell) * dpsi(j,k,ell)) | |||
| """, | |||
| assumptions="nels>=1 and nbf >= 1 and nels mod 4 = 0") | |||
|
|
|||
| print(knl) | |||
| logger.info("%s", knl) | |||
There was a problem hiding this comment.
This is kind of a weird pattern to me. Does logger.info(knl) not work?
There was a problem hiding this comment.
I never actually tried that, but yeah, seems to work! :)) That would have been much easier to search and replace..
There was a problem hiding this comment.
I'm not sure I'm in love with these changes. print seems just fine to me; pytest suppresses stdout anyway. Could you explain the motivation a bit?
There was a problem hiding this comment.
I can't say I feel very strongly about this, so feel free to drop it. 😕
I mostly tried to use logging things because (1) they can write to stderr (by default, right?) or files and (2) add time stamps and things like that. But yeah, not sure those are super useful in tests..
|
Thanks for responding! I think I might just leave this here for now. Maybe it'll turn out later that we want it. 🙂 |
cc @alexfikl