Use serializier from djangorestframework for api. #723
+242
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhuang
force-pushed
the
rest_serializer
branch
3 times, most recently
from
fdae2ef to
f12972e
Compare
joshuata
reviewed
Jul 29, 2020
Comment on lines
+131
to
+135
| def get_percentage(self, obj): | ||
| if obj.correctness is not None: | ||
| return 100 * obj.correctness | ||
| else: | ||
| return None |
Collaborator
There was a problem hiding this comment.
Do we want to make this a read-only property on the FlowPageVisitGrade class instead of the serializer?
Contributor
Author
There was a problem hiding this comment.
Thanks for your review. What's your opinion? @inducer
joshuata
reviewed
Jul 29, 2020
Collaborator
joshuata
left a comment
joshuata
left a comment
There was a problem hiding this comment.
It looks good to me. I only had the one piece of feedback, and it's not blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #719 .