Skip to content

Fix Api Endpoint Error #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaisarturan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Api Endpoint Error #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
756a215
Fix 400 Client Error
kaisarturan Jan 9, 2023
0174aad
Refector: Unused parameter removed
kaisarturan Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions growattServer/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,15 +595,12 @@ def update_plant_settings(self, plant_id, changed_settings, current_settings = N
data = json.loads(response.content.decode('utf-8'))
return data

def update_inverter_setting(self, serial_number, setting_type,
default_parameters, parameters):
def update_inverter_setting(self, default_parameters, parameters):
"""
Applies settings for specified system based on serial number
See README for known working settings

Arguments:
serial_number -- Serial number (device_sn) of the inverter (str)
setting_type -- Setting to be configured (str)
default_params -- Default set of parameters for the setting call (dict)
parameters -- Parameters to be sent to the system (dict or list of str)
(array which will be converted to a dictionary)
Expand All @@ -621,8 +618,8 @@ def update_inverter_setting(self, serial_number, setting_type,

settings_parameters = {**default_parameters, **settings_parameters}

response = self.session.post(self.get_url('newTcpsetAPI.do'),
params=settings_parameters)
response = self.session.post(self.get_url('tcpSet.do'),
data=settings_parameters)
data = json.loads(response.content.decode('utf-8'))
return data

Expand All @@ -645,8 +642,7 @@ def update_mix_inverter_setting(self, serial_number, setting_type, parameters):
'serialNum': serial_number,
'type': setting_type
}
return self.update_inverter_setting(serial_number, setting_type,
default_parameters, parameters)
return self.update_inverter_setting(default_parameters, parameters)

def update_ac_inverter_setting(self, serial_number, setting_type, parameters):
"""
Expand All @@ -667,5 +663,4 @@ def update_ac_inverter_setting(self, serial_number, setting_type, parameters):
'serialNum': serial_number,
'type': setting_type
}
return self.update_inverter_setting(serial_number, setting_type,
default_parameters, parameters)
return self.update_inverter_setting(default_parameters, parameters)