Added get_mix_inverter_settings to retrive data

[LasseBang]

Added get_mix_inverter_settings to retrive data such at time for discharge/charge

[muppet3000]

Please can you update the readme.md file to add information about the new function and how to use it (we have this for all of the other functions)?

[LasseBang]

Please can you update the readme.md file to add information about the new function and how to use it (we have this for all of the other functions)?

Done :-)

[AnonTester]

Please merge this. Very useful PR.

[LasseBang]

indeed!

[indykoning]

I was going to merge this in but just want to check one small thing if the indenting is correct here

[indykoning]

The indenting looks off, so a sanity check. Isn't this the right indenting?

Suggested change

	def get_mix_inverter_settings(self, serial_number):
	def get_mix_inverter_settings(self, serial_number):

[indykoning]

I see this is not used, probably a leftover

Suggested change

settings_params = {**default_params}

[LasseBang]

Hi, yes your change looks right 😊 Fra: indykoning ***@***.***> Dato: søndag, 13. august 2023 kl. 19.56 Til: indykoning/PyPi_GrowattServer ***@***.***> Cc: Lasse Bang ***@***.***>, Author ***@***.***> Emne: Re: [indykoning/PyPi_GrowattServer] Added get_mix_inverter_settings to retrive data (PR #59) @indykoning commented on this pull request. I was going to merge this in but just want to check one small thing if the indenting is correct here

________________________________ In growattServer/__init__.py<#59 (comment)>:

@@ -669,3 +669,23 @@ def update_ac_inverter_setting(self, serial_number, setting_type, parameters):

} return self.update_inverter_setting(serial_number, setting_type, default_parameters, parameters) + + def get_mix_inverter_settings(self, serial_number): The indenting looks off, so a sanity check. Isn't this the right indenting? ⬇️ Suggested change - def get_mix_inverter_settings(self, serial_number): + def get_mix_inverter_settings(self, serial_number):

________________________________ In growattServer/__init__.py<#59 (comment)>:

+ def get_mix_inverter_settings(self, serial_number):

+ + """ + Gets the inverter settings related to battery modes + Keyword arguments: + serial_number -- The serial number (device_sn) of the inverter + Returns: + A dictionary of settings + """ + + default_params = { + 'op': 'getMixSetParams', + 'serialNum': serial_number, + 'kind': 0 + } + settings_params = {**default_params} I see this is not used, probably a leftover ⬇️ Suggested change - settings_params = {**default_params} — Reply to this email directly, view it on GitHub<#59 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AG5V2R6BCE5RCYEHXE57BWDXVEILRANCNFSM6AAAAAAVXWFKDE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[simonrankine]

Hi all, I'm quite interested in the functionality this PR introduces, and it seems a shame to let it languish. If the PR has been abandoned I'd happily adopt it to get it over the line if required. Any thoughts @LasseBang @indykoning @muppet3000 ?

[simonrankine]

In order to unblock what I'm working on with this, I've forked this repo here https://github.com/simonrankine/GrowattServer and published the library with these changes included as growattServerSR on PyPI for now if anyone finds this in future and wants this functionality.

I've also opened #90 here, which includes the fixes requested above, in the hope that it will one day get merged and my fork will no longer be needed.

[indykoning]

Closing in favor of #90