[Inertia 3.x] Refactoring: shared_props, hooks, etc#340
Open
skryukov wants to merge 3 commits intov3/ssr-in-developmentfrom
Open
[Inertia 3.x] Refactoring: shared_props, hooks, etc#340skryukov wants to merge 3 commits intov3/ssr-in-developmentfrom
shared_props, hooks, etc#340skryukov wants to merge 3 commits intov3/ssr-in-developmentfrom
Conversation
skryukov
commented
Mar 13, 2026
|
|
||
| def conditionally_share_a_prop | ||
| self.class.inertia_share incorrectly_conditionally_shared_prop: 1 | ||
| inertia_share incorrectly_conditionally_shared_prop: 1 |
Collaborator
Author
There was a problem hiding this comment.
it's now possible! before it would raise an error, but now it's actually safe to call it
skryukov
force-pushed
the
v3/ssr-in-development
branch
from
dcf30f7 to
e59cfb9
Compare
skryukov
force-pushed
the
v3/refactorings-i-always-dreamed-of
branch
from
03fbfb1 to
0b38491
Compare
skryukov
changed the title
shared_props, hooks, etcshared_props, hooks, etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactorings including:
inertia_shareinertia_rails.rbfiles in one - always been kinda confusing to me