Skip to content

Conversation

@qinling0210
Copy link
Contributor

@qinling0210 qinling0210 commented Oct 28, 2025

What problem does this PR solve?

During checkpoint, we persist data to obj. If the data exists in pm, we persist the data to new obj and then delete the old obj.

If infinity is killed just before old obj is deleted, the obj will be stale and not corresponding to any file path.

We will clean the stale obj during cleanup.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

@qinling0210 qinling0210 self-assigned this Oct 28, 2025
@qinling0210 qinling0210 added ci PR can be test slow-test To trigger slow test labels Oct 28, 2025
@qinling0210 qinling0210 added ci PR can be test slow-test To trigger slow test and removed ci PR can be test slow-test To trigger slow test labels Oct 29, 2025
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 67.64706% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.12%. Comparing base (2875eb0) to head (d02f4e0).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...c/storage/persistence/persistence_manager_impl.cpp 63.06% 39 Missing and 2 partials ⚠️
src/storage/new_txn/new_txn_impl.cpp 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3051      +/-   ##
==========================================
+ Coverage   46.68%   47.12%   +0.44%     
==========================================
  Files         724      725       +1     
  Lines      194068   194485     +417     
  Branches    27281    27801     +520     
==========================================
+ Hits        90605    91657    +1052     
+ Misses      93901    93257     -644     
- Partials     9562     9571       +9     
Flag Coverage Δ
debug http test 28.00% <66.91%> (+0.05%) ⬆️
debug parallel test 18.29% <66.91%> (+0.16%) ⬆️
debug pysdk test 30.11% <66.91%> (+0.40%) ⬆️
debug sqllogical test 32.65% <66.91%> (+0.49%) ⬆️
debug unit test 30.40% <65.44%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@qinling0210 qinling0210 added ci PR can be test slow-test To trigger slow test and removed ci PR can be test slow-test To trigger slow test labels Oct 29, 2025
@qinling0210 qinling0210 added ci PR can be test and removed ci PR can be test slow-test To trigger slow test labels Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci PR can be test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants