Add CleanupStaleObjectData()#3051
Draft
qinling0210 wants to merge 6 commits into
Draft
Conversation
yuzhichang
reviewed
Oct 28, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3051 +/- ##
==========================================
+ Coverage 46.68% 47.12% +0.44%
==========================================
Files 724 725 +1
Lines 194068 194485 +417
Branches 27281 27801 +520
==========================================
+ Hits 90605 91657 +1052
+ Misses 93901 93257 -644
- Partials 9562 9571 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
During checkpoint, we persist data to obj. If the data exists in pm, we persist the data to new obj and then delete the old obj.
If infinity is killed just before old obj is deleted, the obj will be stale and not corresponding to any file path.
We will clean the stale obj during cleanup.
Type of change