Skip to content

Conversation

@zpf121
Copy link
Contributor

@zpf121 zpf121 commented Nov 21, 2025

optimize system snapshot

origin:
checkpoint --> create snapshot

now:
create snapshot

JinHai-CN and others added 27 commits November 18, 2025 16:59
Signed-off-by: jinhai <[email protected]>
Signed-off-by: jinhai <[email protected]>
Signed-off-by: jinhai <[email protected]>
Signed-off-by: jinhai <[email protected]>
Signed-off-by: jinhai <[email protected]>
Signed-off-by: jinhai <[email protected]>
# Conflicts:
#	src/storage/new_txn/base_txn_store.cppm
#	src/storage/new_txn/base_txn_store_impl.cpp
#	src/storage/new_txn/new_txn.cppm
#	src/storage/new_txn/new_txn_impl.cpp
#	src/storage/new_txn/txn_state.cppm
#	src/storage/wal/wal_entry.cppm
#	src/storage/wal/wal_entry_impl.cpp
#	src/unit_test/storage/txn/database_snapshot_ut.cpp
@zpf121 zpf121 added the ci PR can be test label Nov 21, 2025
@zpf121 zpf121 marked this pull request as draft November 21, 2025 06:45
@zpf121 zpf121 marked this pull request as ready for review November 21, 2025 06:45
Signed-off-by: jinhai <[email protected]>
Signed-off-by: jinhai <[email protected]>
Signed-off-by: jinhai <[email protected]>
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 59.06615% with 526 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.78%. Comparing base (888bbc8) to head (6ea581b).

Files with missing lines Patch % Lines
src/parser/search_parser.cpp 57.51% 131 Missing and 81 partials ⚠️
src/storage/new_txn/new_txn_impl.cpp 60.09% 140 Missing and 30 partials ⚠️
src/storage/wal/wal_entry_impl.cpp 37.34% 48 Missing and 4 partials ⚠️
src/parser/search_parser.h 55.33% 29 Missing and 17 partials ⚠️
src/storage/common/snapshot_info_impl.cpp 63.01% 19 Missing and 8 partials ⚠️
src/executor/operator/physical_command_impl.cpp 42.85% 2 Missing and 2 partials ⚠️
...xecutor/operator/snapshot/system_snapshot_impl.cpp 69.23% 2 Missing and 2 partials ⚠️
src/parser/expression_parser.h 63.63% 2 Missing and 2 partials ⚠️
src/storage/new_txn/base_txn_store_impl.cpp 91.17% 3 Missing ⚠️
src/parser/parser.h 81.81% 0 Missing and 2 partials ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3109      +/-   ##
==========================================
+ Coverage   46.70%   46.78%   +0.08%     
==========================================
  Files         724      725       +1     
  Lines      150823   151598     +775     
  Branches    27446    27574     +128     
==========================================
+ Hits        70443    70929     +486     
- Misses      70713    70967     +254     
- Partials     9667     9702      +35     
Flag Coverage Δ
debug http test 27.30% <25.75%> (-0.45%) ⬇️
debug parallel test 17.60% <16.34%> (-0.10%) ⬇️
debug pysdk test 29.40% <25.21%> (-0.18%) ⬇️
debug sqllogical test 31.78% <19.92%> (-0.10%) ⬇️
debug unit test 32.03% <53.30%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci PR can be test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants