Skip to content

feat: add optional cache busting for image #12055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinHuSh merged 1 commit into from
Dec 22, 2025
Merged

feat: add optional cache busting for image #12055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions web/src/components/image/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@ interface IImage {
id: string;
className?: string;
onClick?(): void;
t?: string | number;
}

const Image = ({ id, className, ...props }: IImage) => {
const Image = ({ id, t, className, ...props }: IImage) => {
return (
<img
{...props}
src={`${api_host}/document/image/${id}`}
src={`${api_host}/document/image/${id}${t ? `?_t=${t}` : ''}`}
alt=""
className={classNames('max-w-[45vw] max-h-[40wh] block', className)}
/>
Expand Down
8 changes: 7 additions & 1 deletion web/src/hooks/use-chunk-request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export interface IChunkListResult {
setPagination?: (pagination: { page: number; pageSize: number }) => void;
available: number | undefined;
handleSetAvailable: (available: number | undefined) => void;
dataUpdatedAt?: number; // Timestamp when data was last updated - useful for cache busting
}

export const useSelectChunkList = () => {
Expand Down Expand Up @@ -118,7 +119,11 @@ export const useFetchNextChunkList = (
const [available, setAvailable] = useState<number | undefined>();
const debouncedSearchString = useDebounce(searchString, { wait: 500 });

const { data, isFetching: loading } = useQuery({
const {
data,
isFetching: loading,
dataUpdatedAt,
} = useQuery({
queryKey: [
'fetchChunkList',
documentId,
Expand Down Expand Up @@ -183,6 +188,7 @@ export const useFetchNextChunkList = (
handleInputChange: onInputChange,
available,
handleSetAvailable,
dataUpdatedAt, // Timestamp when data was last updated - useful for cache busting
};
};

Expand Down
9 changes: 8 additions & 1 deletion ...nk/parsed-result/add-knowledge/components/knowledge-chunk/components/chunk-card/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ interface IProps {
selected: boolean;
clickChunkCard: (chunkId: string) => void;
textMode: ChunkTextMode;
t?: string | number; // Cache-busting key for images
}

const ChunkCard = ({
Expand All @@ -36,6 +37,7 @@ const ChunkCard = ({
selected,
clickChunkCard,
textMode,
t: imageCacheKey,
}: IProps) => {
const available = Number(item.available_int);
const [enabled, setEnabled] = useState(false);
Expand Down Expand Up @@ -79,7 +81,11 @@ const ChunkCard = ({
onMouseLeave={() => setOpen(false)}
>
<div>
<Image id={item.image_id} className={styles.image}></Image>
<Image
t={imageCacheKey}
id={item.image_id}
className={styles.image}
/>
</div>
</PopoverTrigger>
<PopoverContent
Expand All @@ -90,6 +96,7 @@ const ChunkCard = ({
>
<div>
<Image
t={imageCacheKey}
id={item.image_id}
className={styles.imagePreview}
></Image>
Expand Down
2 changes: 2 additions & 0 deletions web/src/pages/chunk/parsed-result/add-knowledge/components/knowledge-chunk/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ const Chunk = () => {
handleInputChange,
available,
handleSetAvailable,
dataUpdatedAt,
} = useFetchNextChunkList();
const { handleChunkCardClick, selectedChunkId } = useHandleChunkCardClick();
const isPdf = documentInfo?.type === 'pdf';
Expand Down Expand Up @@ -277,6 +278,7 @@ const Chunk = () => {
clickChunkCard={handleChunkCardClick}
selected={item.chunk_id === selectedChunkId}
textMode={textMode}
t={dataUpdatedAt}
></ChunkCard>
))}
</div>
Expand Down