Skip to content

fix: correct typo in IterationItem name check and incomplete error message#13890

Merged
yingfeng merged 1 commit intoinfiniflow:mainfrom
Ricardo-M-L:fix/typo-interationitem-and-incomplete-error
Apr 2, 2026
Merged

fix: correct typo in IterationItem name check and incomplete error message#13890
yingfeng merged 1 commit intoinfiniflow:mainfrom
Ricardo-M-L:fix/typo-interationitem-and-incomplete-error

Conversation

@Ricardo-M-L
Copy link
Copy Markdown
Contributor

Two small fixes:

  1. iterationitem.py line 72: Typo "interationitem" → "iterationitem" (missing 't'). The component name check never matched IterationItem components.

  2. raptor.py line 94: Error message "Embedding error: " had a trailing colon with no details. Changed to "Embedding error: empty embeddings returned".

- iterationitem.py line 72: "interationitem" → "iterationitem" (missing 't')
  This caused IterationItem components to not match the name check.
- raptor.py line 94: "Embedding error: " → "Embedding error: empty embeddings returned"
  The original message had a trailing colon with no details.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working, pull request that fix bug. labels Apr 1, 2026
@yingfeng yingfeng added the ci Continue Integration label Apr 2, 2026
@yingfeng yingfeng marked this pull request as draft April 2, 2026 02:00
@yingfeng yingfeng marked this pull request as ready for review April 2, 2026 02:03
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.52%. Comparing base (af40be6) to head (49682b1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13890      +/-   ##
==========================================
- Coverage   98.11%   96.52%   -1.60%     
==========================================
  Files          10       10              
  Lines         690      690              
  Branches      108      108              
==========================================
- Hits          677      666      -11     
- Misses          4        8       +4     
- Partials        9       16       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yingfeng yingfeng merged commit 09a09a5 into infiniflow:main Apr 2, 2026
1 check passed
sirj0k3r pushed a commit to sirj0k3r/ragflow that referenced this pull request Apr 2, 2026
…ssage (infiniflow#13890)

Two small fixes:

1. **iterationitem.py line 72**: Typo "interationitem" → "iterationitem"
(missing 't'). The component name check never matched IterationItem
components.

2. **raptor.py line 94**: Error message "Embedding error: " had a
trailing colon with no details. Changed to "Embedding error: empty
embeddings returned".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working, pull request that fix bug. ci Continue Integration size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants