Skip to content

Fix: markdown table double extraction in parser #13892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asiroliu merged 2 commits into from
Apr 2, 2026
+7 −5
Merged

Fix: markdown table double extraction in parser #13892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8de610
Fix markdown table double extraction in parser
6ba3i Apr 2, 2026
f64d214
fix ci
6ba3i Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deepdoc/parser/markdown_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def replace_tables_with_rendered_html(pattern, table_list, render=True):
""",
re.VERBOSE,
)
working_text = replace_tables_with_rendered_html(border_table_pattern, tables)
working_text = replace_tables_with_rendered_html(border_table_pattern, tables, render=separate_tables)

# Borderless Markdown table
no_border_table_pattern = re.compile(
Expand All @@ -68,7 +68,7 @@ def replace_tables_with_rendered_html(pattern, table_list, render=True):
""",
re.VERBOSE,
)
working_text = replace_tables_with_rendered_html(no_border_table_pattern, tables)
working_text = replace_tables_with_rendered_html(no_border_table_pattern, tables, render=separate_tables)

# Replace any TAGS e.g. <table ...> to <table>
TAGS = ["table", "td", "tr", "th", "tbody", "thead", "div"]
Expand Down
8 changes: 5 additions & 3 deletions test/testcases/test_sdk_api/test_chunk_management_within_dataset/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#


from time import sleep

import pytest
from common import batch_add_chunks, delete_all_chunks
Expand All @@ -32,6 +31,10 @@ def condition(_dataset: DataSet):
return False
return True

@wait_for(30, 1, "Chunk indexing timeout")
def chunks_visible(_document: Document, _chunk_ids: list[str]):
visible_ids = {chunk.id for chunk in _document.list_chunks(page_size=1000)}
return set(_chunk_ids).issubset(visible_ids)

@pytest.fixture(scope="function")
def add_chunks_func(request: FixtureRequest, add_document: tuple[DataSet, Document]) -> tuple[DataSet, Document, list[Chunk]]:
Expand All @@ -47,6 +50,5 @@ def cleanup():
dataset.async_parse_documents([document.id])
condition(dataset)
chunks = batch_add_chunks(document, 4)
# issues/6487
sleep(1)
chunks_visible(document, [chunk.id for chunk in chunks])
return dataset, document, chunks
Loading