feat: make Azure cloud authority configurable for SPN auth#13898
Open
yuzhichang wants to merge 1 commit intoinfiniflow:mainfrom
Open
feat: make Azure cloud authority configurable for SPN auth#13898yuzhichang wants to merge 1 commit intoinfiniflow:mainfrom
yuzhichang wants to merge 1 commit intoinfiniflow:mainfrom
Conversation
dosubot
bot
added
the
size:S
The Azure SPN storage handler hardcoded AzureAuthorityHosts.AZURE_CHINA, preventing users in Azure Public Cloud regions (UK-South, EU, US, etc.) from authenticating. Add a `cloud` config option (env: AZURE_CLOUD) supporting all four Azure sovereignties: public, china, government, germany. Defaults to "public" (global Azure). Closes infiniflow#13259 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yuzhichang
force-pushed
the
emdash/feat-request-azure-public-4gc
branch
from
d9a53af to
edc5339
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13898 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 10 10
Lines 690 690
Branches 108 108
=======================================
Hits 666 666
Misses 8 8
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AzureAuthorityHosts.AZURE_CHINA, preventing users in Azure Public Cloud regions (UK-South, EU, US, etc.) from authenticatingcloudconfig option (env:AZURE_CLOUD) supporting all four Azure sovereignties:public,china,government,germanypublic(global Azure) — the most common international use caseCloses #13259
Test plan
cloud: public) connects to Azure Public Cloud endpointscloud: chinaretains existing behavior for Azure China usersAZURE_CLOUDenv var overrides the config file value🤖 Generated with Claude Code